Browse Source

Исправление ошибки в SqlCriteria.count() - дублирующееся COUNT(COUNT( * во внутреннем sql-запросе

namespace
Alexander Demidov 10 years ago
parent
commit
b6e002f5a8
  1. 7
      Model/SqlCriteria.php
  2. 4
      Model/SqlModel.php

7
Model/SqlCriteria.php

@ -79,16 +79,17 @@ class SqlCriteria
return $this->model->find('', '', $this->where, null, null, null, null, 'DELETE FROM :table', $this->sql_expression_params)->affectedRows(); return $this->model->find('', '', $this->where, null, null, null, null, 'DELETE FROM :table', $this->sql_expression_params)->affectedRows();
} }
//TODO: перенести определение sql_expression в модель
public function count($select = null) public function count($select = null)
{ {
$this->defineJoinExpressions($select); $this->defineJoinExpressions($select);
$sql_expression_backup = $this->sql_expression; $sql_expression_backup = $this->sql_expression;
$select = 'COUNT(*) as count';
$select_parent_query = 'COUNT(*) as count';
if (!$this->sql_expression) { if (!$this->sql_expression) {
$this->sql_expression = 'SELECT COUNT(' . ($select ? $select : '*') . ') as count FROM :table'; $this->sql_expression = 'SELECT COUNT(' . ($select ? $select : '*') . ') as count FROM :table';
$select = 'x.count';
$select_parent_query = 'x.count';
} }
$count = $this->model->count($select, $this->where, null, $this->group_by, $this->sql_expression, $this->sql_expression_params)->fetchField('count');
$count = $this->model->count($select_parent_query, $this->where, null, $this->group_by, $this->sql_expression, $this->sql_expression_params)->fetchField('count');
$this->sql_expression = $sql_expression_backup; $this->sql_expression = $sql_expression_backup;
return $count; return $count;
} }

4
Model/SqlModel.php

@ -226,12 +226,12 @@ abstract class SqlModel extends Model
return new SqlResultProvider($result); return new SqlResultProvider($result);
} }
public function count($select = 'x.count', $where, $heaving = null, $group_by = null, $sql_expression = null, $sql_expression_params = array(), $cache_key = null)
public function count($select_parent_query = 'x.count', $where, $heaving = null, $group_by = null, $sql_expression = null, $sql_expression_params = array(), $cache_key = null)
{ {
$where = $this->db->whereExpr($where); $where = $this->db->whereExpr($where);
$group_by = $this->db->groupByExpr($group_by); $group_by = $this->db->groupByExpr($group_by);
$result = $this->query( $result = $this->query(
'SELECT ' . $select . ' FROM (' .
'SELECT ' . $select_parent_query . ' FROM (' .
(($sql_expression) ? $sql_expression : ('SELECT * FROM ' . $this->identify($this->table()))) (($sql_expression) ? $sql_expression : ('SELECT * FROM ' . $this->identify($this->table())))
. (($where) ? (' WHERE ' . $where) : '') . (($where) ? (' WHERE ' . $where) : '')
. (($group_by) ? (' GROUP BY ' . $group_by) : '') . ') AS x', . (($group_by) ? (' GROUP BY ' . $group_by) : '') . ') AS x',

Loading…
Cancel
Save