Browse Source

Code formatting for ViewHelper & tests

master
Anton Terekhov 12 years ago
parent
commit
07a244ca35
  1. 34
      tests/view/helpers/BreadcrumbVeiwHelperTest.php
  2. 16
      tests/view/helpers/GetViewHelperTest.php
  3. 25
      tests/view/helpers/HeadViewHelperTest.php
  4. 23
      tests/view/helpers/MsgViewHelperTest.php
  5. 24
      tests/view/helpers/TitleViewHelperTest.php
  6. 12
      view/helpers/BreadcrumbViewHelper.php
  7. 10
      view/helpers/GetViewHelper.php
  8. 4
      view/helpers/HeadViewHelper.php
  9. 6
      view/helpers/MsgViewHelper.php
  10. 8
      view/helpers/TitleViewHelper.php
  11. 4
      view/helpers/ViewHelper.php

34
tests/view/helpers/BreadcrumbVeiwHelperTest.php

@ -16,45 +16,47 @@ require_once dirname(__FILE__) . '/../../../view/helpers/BreadcrumbViewHelper.ph
class BreadcrumbViewHelperTest extends PHPUnit_Framework_TestCase class BreadcrumbViewHelperTest extends PHPUnit_Framework_TestCase
{ {
/**
* @var BreadcrumbViewHelper
*/
public $helper; public $helper;
public function setUp() public function setUp()
{ {
Registry::set('BreadcrumbViewHelper', array()); Registry::set('BreadcrumbViewHelper', array());
$this->helper = new BreadcrumbViewHelper(new PHPView('any')); $this->helper = new BreadcrumbViewHelper(new PHPView('any'));
} }
public function testTitle() public function testTitle()
{ {
$this->helper->breadcrumb('Guest page', 'guest.php');
$this->helper->breadcrumb('Guest page', 'guest.php');
$result = Registry::get('BreadcrumbViewHelper'); $result = Registry::get('BreadcrumbViewHelper');
$this->assertSame(array('Guest page' => 'guest.php'), Registry::get('BreadcrumbViewHelper'));
$this->assertSame(array('Guest page' => 'guest.php'), Registry::get('BreadcrumbViewHelper'));
$this->helper->prepend('Leave message', 'feedback.php'); $this->helper->prepend('Leave message', 'feedback.php');
$this->assertSame(array('Leave message' => 'feedback.php', 'Guest page' => 'guest.php'), Registry::get('BreadcrumbViewHelper'));
$this->assertSame(array('Leave message' => 'feedback.php', 'Guest page' => 'guest.php'), Registry::get('BreadcrumbViewHelper'));
$this->helper->append('Home page', 'home.php'); $this->helper->append('Home page', 'home.php');
$this->assertSame(array('Leave message' => 'feedback.php', 'Guest page' => 'guest.php', 'Home page' => 'home.php'), Registry::get('BreadcrumbViewHelper'));
$this->assertSame(array('Leave message' => 'feedback.php', 'Guest page' => 'guest.php', 'Home page' => 'home.php'), Registry::get('BreadcrumbViewHelper'));
} }
public function testToString() public function testToString()
{ {
$this->helper->prepend('Home page', 'home.php'); $this->helper->prepend('Home page', 'home.php');
$this->helper->breadcrumb('Guest page', 'guest.php');
$this->helper->breadcrumb('Guest page', 'guest.php');
$this->helper->append('Leave message', 'feedback.php'); $this->helper->append('Leave message', 'feedback.php');
$this->assertSame(array('Home page' => 'home.php', 'Guest page' => 'guest.php', 'Leave message'=> 'feedback.php'), Registry::get('BreadcrumbViewHelper'));
$this->assertSame(array('Home page' => 'home.php', 'Guest page' => 'guest.php', 'Leave message' => 'feedback.php'), Registry::get('BreadcrumbViewHelper'));
$result = $this->helper->__toString(); $result = $this->helper->__toString();
$this->assertSame('<a href="home.php">Home page</a> &gt; <a href="guest.php">Guest page</a> &gt; <a href="feedback.php">Leave message</a>', $result); $this->assertSame('<a href="home.php">Home page</a> &gt; <a href="guest.php">Guest page</a> &gt; <a href="feedback.php">Leave message</a>', $result);
$this->helper->setSeparator('-'); $this->helper->setSeparator('-');
$result = $this->helper->__toString(); $result = $this->helper->__toString();
$this->assertSame('<a href="home.php">Home page</a>-<a href="guest.php">Guest page</a>-<a href="feedback.php">Leave message</a>', $result); $this->assertSame('<a href="home.php">Home page</a>-<a href="guest.php">Guest page</a>-<a href="feedback.php">Leave message</a>', $result);
$this->helper->append('Last page', ''); $this->helper->append('Last page', '');
$result = $this->helper->__toString(); $result = $this->helper->__toString();
$this->assertSame('<a href="home.php">Home page</a>-<a href="guest.php">Guest page</a>-<a href="feedback.php">Leave message</a>-Last page', $result); $this->assertSame('<a href="home.php">Home page</a>-<a href="guest.php">Guest page</a>-<a href="feedback.php">Leave message</a>-Last page', $result);
} }
} }

16
tests/view/helpers/GetViewHelperTest.php

@ -18,14 +18,17 @@ require_once dirname(__FILE__) . '/../../../view/helpers/GetViewHelper.php';
class GetViewHelperTest extends PHPUnit_Framework_TestCase class GetViewHelperTest extends PHPUnit_Framework_TestCase
{ {
/**
* @var GetViewHelper
*/
public $helper; public $helper;
public function setUp() public function setUp()
{ {
$this->helper = new GetViewHelper(new PHPView('any')); $this->helper = new GetViewHelper(new PHPView('any'));
} }
/** /**
* @TODO: GetViewHelper: initialize GetViewHelper::$get with empty array() * @TODO: GetViewHelper: initialize GetViewHelper::$get with empty array()
*/ */
@ -34,7 +37,7 @@ class GetViewHelperTest extends PHPUnit_Framework_TestCase
$this->setExpectedException('PHPUnit_Framework_Error'); $this->setExpectedException('PHPUnit_Framework_Error');
$this->helper->get(null); $this->helper->get(null);
} }
/** /**
* @TODO: GetViewHelper: check $_GET not null * @TODO: GetViewHelper: check $_GET not null
*/ */
@ -43,7 +46,7 @@ class GetViewHelperTest extends PHPUnit_Framework_TestCase
$this->setExpectedException('PHPUnit_Framework_Error'); $this->setExpectedException('PHPUnit_Framework_Error');
$result = $this->helper->get('param'); $result = $this->helper->get('param');
} }
public function testGetWithSingleParam() public function testGetWithSingleParam()
{ {
$_GET['a'] = 'b'; $_GET['a'] = 'b';
@ -59,7 +62,7 @@ class GetViewHelperTest extends PHPUnit_Framework_TestCase
$result = $this->helper->get(array('a')); $result = $this->helper->get(array('a'));
$this->assertSame('?b=a', $result); $this->assertSame('?b=a', $result);
} }
public function testGetWithArray() public function testGetWithArray()
{ {
$_GET['a'] = array('one' => 1, 'two' => 2); $_GET['a'] = array('one' => 1, 'two' => 2);
@ -77,5 +80,4 @@ class GetViewHelperTest extends PHPUnit_Framework_TestCase
$result = $this->helper->get(array('b' => 'c d e', 'c' => array('five' => 'six seven'))); $result = $this->helper->get(array('b' => 'c d e', 'c' => array('five' => 'six seven')));
$this->assertSame('?a[one]=1&amp;a[two]=2&amp;b=c+d+e&amp;c[five]=six+seven', $result); $this->assertSame('?a[one]=1&amp;a[two]=2&amp;b=c+d+e&amp;c[five]=six+seven', $result);
} }
} }

25
tests/view/helpers/HeadViewHelperTest.php

@ -16,32 +16,35 @@ require_once dirname(__FILE__) . '/../../../view/helpers/HeadViewHelper.php';
class HeadViewHelperTest extends PHPUnit_Framework_TestCase class HeadViewHelperTest extends PHPUnit_Framework_TestCase
{ {
/**
* @var HeadViewHelper
*/
public $helper; public $helper;
public function setUp() public function setUp()
{ {
Registry::set('HeadViewHelper', array()); Registry::set('HeadViewHelper', array());
$this->helper = new HeadViewHelper(null); $this->helper = new HeadViewHelper(null);
} }
public function testHead() public function testHead()
{ {
$this->helper->head('<meta />');
$this->helper->head('<meta />');
$result = Registry::get('HeadViewHelper'); $result = Registry::get('HeadViewHelper');
$this->assertSame(array('<meta />'), Registry::get('HeadViewHelper')); $this->assertSame(array('<meta />'), Registry::get('HeadViewHelper'));
$this->helper->head('<link />');
$this->helper->head('<link />');
$this->assertSame(array('<meta />', '<link />'), Registry::get('HeadViewHelper')); $this->assertSame(array('<meta />', '<link />'), Registry::get('HeadViewHelper'));
} }
public function testToString() public function testToString()
{ {
$this->helper->head('<meta />');
$this->helper->head('<link />');
$this->helper->head('<meta />');
$this->helper->head('<link />');
$result = $this->helper->__toString(); $result = $this->helper->__toString();
$this->assertSame("<meta />\n <link />\n", $result); $this->assertSame("<meta />\n <link />\n", $result);
} }
} }

23
tests/view/helpers/MsgViewHelperTest.php

@ -19,25 +19,25 @@ require_once dirname(__FILE__) . '/../../../exception/GeneralException.php';
class MsgViewHelperTest extends PHPUnit_Framework_TestCase class MsgViewHelperTest extends PHPUnit_Framework_TestCase
{ {
/**
* @var MsgViewHelper
*/
public $helper; public $helper;
public function setUp() public function setUp()
{ {
Session::del('MsgViewHelper'); Session::del('MsgViewHelper');
$this->helper = new MsgViewHelper(new PHPView(array('path' => 'any'))); $this->helper = new MsgViewHelper(new PHPView(array('path' => 'any')));
} }
public function testMsg() public function testMsg()
{ {
$this->helper->msg('new message from test', 'success');
$this->helper->msg('new message from test', 'success');
$this->assertSame(array('message' => 'new message from test', 'type' => 'success'), Session::get('MsgViewHelper')); $this->assertSame(array('message' => 'new message from test', 'type' => 'success'), Session::get('MsgViewHelper'));
$this->assertSame($this->helper, $this->helper->msg('error message', 'error'));
$this->assertSame(array('message' => 'error message', 'type' => 'error'), Session::get('MsgViewHelper'));
$this->assertSame($this->helper, $this->helper->msg('error message', 'error'));
$this->assertSame(array('message' => 'error message', 'type' => 'error'), Session::get('MsgViewHelper'));
} }
public function testWrongType() public function testWrongType()
@ -45,13 +45,13 @@ class MsgViewHelperTest extends PHPUnit_Framework_TestCase
$this->setExpectedException('GeneralException', 'Unknown message type'); $this->setExpectedException('GeneralException', 'Unknown message type');
$this->helper->msg('some message', 'wrong'); $this->helper->msg('some message', 'wrong');
} }
public function testSuccess() public function testSuccess()
{ {
$this->helper->success('success message'); $this->helper->success('success message');
$this->assertSame(array('message' => 'success message', 'type' => 'success'), Session::get('MsgViewHelper')); $this->assertSame(array('message' => 'success message', 'type' => 'success'), Session::get('MsgViewHelper'));
} }
public function testError() public function testError()
{ {
$this->helper->error('error message'); $this->helper->error('error message');
@ -65,11 +65,10 @@ class MsgViewHelperTest extends PHPUnit_Framework_TestCase
$result = $this->helper->__toString(); $result = $this->helper->__toString();
$this->assertSame('<div class="success">yeah</div>', $result); $this->assertSame('<div class="success">yeah</div>', $result);
} }
public function testToStringEmpty() public function testToStringEmpty()
{ {
$result = $this->helper->__toString(); $result = $this->helper->__toString();
$this->assertEmpty($result); $this->assertEmpty($result);
} }
} }

24
tests/view/helpers/TitleViewHelperTest.php

@ -16,32 +16,34 @@ require_once dirname(__FILE__) . '/../../../view/helpers/TitleViewHelper.php';
class TitleViewHelperTest extends PHPUnit_Framework_TestCase class TitleViewHelperTest extends PHPUnit_Framework_TestCase
{ {
/**
* @var TitleViewHelper
*/
public $helper; public $helper;
public function setUp() public function setUp()
{ {
Registry::set('TitleViewHelper', array()); Registry::set('TitleViewHelper', array());
$this->helper = new TitleViewHelper('view'); $this->helper = new TitleViewHelper('view');
} }
public function testTitle() public function testTitle()
{ {
$this->helper->title('one');
$this->helper->title('one');
$result = Registry::get('TitleViewHelper'); $result = Registry::get('TitleViewHelper');
$this->assertSame(array('one'), Registry::get('TitleViewHelper')); $this->assertSame(array('one'), Registry::get('TitleViewHelper'));
$this->helper->title('two');
$this->helper->title('two');
$this->assertSame(array('one', 'two'), Registry::get('TitleViewHelper')); $this->assertSame(array('one', 'two'), Registry::get('TitleViewHelper'));
} }
public function testSeparator() public function testSeparator()
{ {
$this->helper->title('one');
$this->helper->title('two');
$this->helper->title('one');
$this->helper->title('two');
$this->assertSame('one - two', $this->helper->__toString()); $this->assertSame('one - two', $this->helper->__toString());
$this->helper->setSeparator('='); $this->helper->setSeparator('=');
$this->assertSame('one=two', $this->helper->__toString());
$this->assertSame('one=two', $this->helper->__toString());
} }
} }

12
view/helpers/BreadcrumbViewHelper.php

@ -11,9 +11,9 @@
class BreadcrumbViewHelper extends ViewHelper class BreadcrumbViewHelper extends ViewHelper
{ {
protected $separator = ' &gt; '; protected $separator = ' &gt; ';
public function breadcrumb($text = false, $href = false) public function breadcrumb($text = false, $href = false)
{ {
if ($text) { if ($text) {
@ -21,22 +21,22 @@ class BreadcrumbViewHelper extends ViewHelper
} }
return $this; return $this;
} }
public function prepend($text, $href) public function prepend($text, $href)
{ {
Registry::set(__CLASS__, array($text => $href) + Registry::get(__CLASS__, array())); Registry::set(__CLASS__, array($text => $href) + Registry::get(__CLASS__, array()));
} }
public function append($text, $href) public function append($text, $href)
{ {
Registry::set(__CLASS__, Registry::get(__CLASS__, array()) + array($text => $href)); Registry::set(__CLASS__, Registry::get(__CLASS__, array()) + array($text => $href));
} }
public function setSeparator($sep) public function setSeparator($sep)
{ {
$this->separator = $sep; $this->separator = $sep;
} }
public function __toString() public function __toString()
{ {
$data = array(); $data = array();

10
view/helpers/GetViewHelper.php

@ -11,9 +11,9 @@
class GetViewHelper extends ViewHelper class GetViewHelper extends ViewHelper
{ {
protected $get; protected $get;
public function get($replace) public function get($replace)
{ {
$get = $this->getSanitizedRequest(); $get = $this->getSanitizedRequest();
@ -29,7 +29,7 @@ class GetViewHelper extends ViewHelper
} }
return '?' . $this->view->escape(implode('&', $get)); return '?' . $this->view->escape(implode('&', $get));
} }
protected function getSanitizedRequest() protected function getSanitizedRequest()
{ {
if ($this->get === null) { if ($this->get === null) {
@ -40,10 +40,10 @@ class GetViewHelper extends ViewHelper
} }
return $this->get; return $this->get;
} }
protected function impl($name, $value) protected function impl($name, $value)
{ {
if (is_array($value)){
if (is_array($value)) {
$result = array(); $result = array();
foreach ($value as $key => $val) { foreach ($value as $key => $val) {
$result[] = $name . '[' . $key . ']=' . urlencode($val); $result[] = $name . '[' . $key . ']=' . urlencode($val);

4
view/helpers/HeadViewHelper.php

@ -11,7 +11,7 @@
class HeadViewHelper extends ViewHelper class HeadViewHelper extends ViewHelper
{ {
public function head($string = false) public function head($string = false)
{ {
if ($string) { if ($string) {
@ -21,7 +21,7 @@ class HeadViewHelper extends ViewHelper
} }
return $this; return $this;
} }
public function __toString() public function __toString()
{ {
return implode("\n ", Registry::get(__CLASS__, array())) . "\n"; return implode("\n ", Registry::get(__CLASS__, array())) . "\n";

6
view/helpers/MsgViewHelper.php

@ -11,7 +11,7 @@
class MsgViewHelper extends ViewHelper class MsgViewHelper extends ViewHelper
{ {
const SUCCESS = 'success'; const SUCCESS = 'success';
const ERROR = 'error'; const ERROR = 'error';
@ -27,12 +27,12 @@ class MsgViewHelper extends ViewHelper
} }
return $this; return $this;
} }
public function success($msg) public function success($msg)
{ {
Session::set(__CLASS__, array('message' => $msg, 'type' => self::SUCCESS)); Session::set(__CLASS__, array('message' => $msg, 'type' => self::SUCCESS));
} }
public function error($msg) public function error($msg)
{ {
Session::set(__CLASS__, array('message' => $msg, 'type' => self::ERROR)); Session::set(__CLASS__, array('message' => $msg, 'type' => self::ERROR));

8
view/helpers/TitleViewHelper.php

@ -11,9 +11,9 @@
class TitleViewHelper extends ViewHelper class TitleViewHelper extends ViewHelper
{ {
protected $separator = ' - '; protected $separator = ' - ';
public function title($string = false) public function title($string = false)
{ {
if ($string) { if ($string) {
@ -23,12 +23,12 @@ class TitleViewHelper extends ViewHelper
} }
return $this; return $this;
} }
public function setSeparator($sep) public function setSeparator($sep)
{ {
$this->separator = $sep; $this->separator = $sep;
} }
public function __toString() public function __toString()
{ {
return implode($this->separator, Registry::get(__CLASS__, array())); return implode($this->separator, Registry::get(__CLASS__, array()));

4
view/helpers/ViewHelper.php

@ -11,12 +11,12 @@
abstract class ViewHelper abstract class ViewHelper
{ {
/** /**
* @var PHPView * @var PHPView
*/ */
protected $view = null; protected $view = null;
public function __construct($view) public function __construct($view)
{ {
$this->view = $view; $this->view = $view;

Loading…
Cancel
Save